Invocation Flow Improvements (Fixes Encoding Problems) #1000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing the problems described in this PR #947 it occurred to me that the way we have implemented
noDecode
is incorrect and incomplete.It does not cover all possible encoding cases:
In order to make the above possible, we need to add the concept of an
invoker
and aninvocable
. This will allow us to have different options / return values:A rough outline of the client implementation: